fixed: opencc does not work under Windows, when opencc files in a path code page incompatible with UTF-8. #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h code page incompatible with UTF-8. example path with Chinese characters.
eagleoflqj
approved these changes
Aug 12, 2023
Closed
groverlynn
pushed a commit
to groverlynn/librime
that referenced
this pull request
Sep 27, 2023
…h code page incompatible with UTF-8. (rime#689) example path with Chinese characters.
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 2, 2023
…h code page incompatible with UTF-8. (rime#689) example path with Chinese characters.
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Nov 8, 2023
…h code page incompatible with UTF-8. (rime#689) example path with Chinese characters.
graphemecluster
pushed a commit
to TypeDuck-HK/librime
that referenced
this pull request
Mar 18, 2024
…h code page incompatible with UTF-8. (rime#689) example path with Chinese characters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issue
Fixes #
under Windows, with weasel, user_dir and shared_dir encoded in CP_ACP ( depend on code page setting ), if opencc file in those paths with NONE ASCII code (for example with simplified Chinese Windows code page CP936, user_dir with chinese characters ), it will make opencc hanged.
Feature
Describe feature of pull request
Unit test
Manual test
Code Review
Additional Info